Remove rustfmt from progenitor-impl #368
Conversation
|
If this is what you had in mind, I'll update the README etc. |
| @@ -505,41 +505,19 @@ impl Generator { | |||
|
|
|||
| /// Render text output. | |||
There was a problem hiding this comment.
I think we should just delete generate_text and generatex_text_normalize_comments
There was a problem hiding this comment.
generate_text has been in the README.md sample build.rs.
There was a problem hiding this comment.
still! let's get rid of them!
| @@ -26,6 +26,16 @@ where | |||
| } | |||
| } | |||
|
|
|||
| fn generate_formatted(generator: &mut Generator, spec: &OpenAPI) -> String { | |||
There was a problem hiding this comment.
Let's make the goal to have no changes in the output fixtures
There was a problem hiding this comment.
There is still one changed fixture - progenitor-impl/tests/output/nexus-cli.out - this is because the removed formatting code in cli.rs had different rustfmt settings, specifically it used only format_strings: Some(true), which wasnt used in lib.rs.
There was a problem hiding this comment.
What's it look like if we format_strings: Some(true) for everything?
There was a problem hiding this comment.
IMO it looks great - it does however change the non-cli .out files, so was optional which approach to take. I'll add it and you can judge for yourself, but IMO it is worth the extra changes.
|
ready to roll @ahl |
|
Thanks for doing this! |
Closes #362